]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/gt: nuke unused legacy engine hw_id
authorLucas De Marchi <lucas.demarchi@intel.com>
Tue, 20 Jul 2021 23:20:12 +0000 (16:20 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Fri, 23 Jul 2021 00:02:14 +0000 (17:02 -0700)
commite02380bd601179149da6c460bebe2e9d53f3c85b
treecdc5154516ada333e7daca141d0a7eaf9e4014af
parente7d2863454e9222c7d18f1b0ea23cbea0a0f7030
drm/i915/gt: nuke unused legacy engine hw_id

The engine hw_id is only used by RING_FAULT_REG(), which is not used
by GRAPHICS_VER >= 8. We did use hw_id on recent platforms to set
the engine's guc_id, but that is not the case anymore since
commit 84c63b43eef2 ("drm/i915/guc: Update to use firmware v49.0.1"):
now we only use class and id information to generate guc_id.

We tend to keep adding new defines just to be consistent, but let's try
to remove them and let them defined to 0 for engines that only exist on
gen8+ platforms.

v2: Reword commit message and add information about when we stopped
using hw_id (Matt Roper)

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210720232014.3302645-3-lucas.demarchi@intel.com
drivers/gpu/drm/i915/gt/intel_engine_cs.c
drivers/gpu/drm/i915/gt/intel_engine_types.h