]> git.baikalelectronics.ru Git - kernel.git/commit
dmaengine: dma-jz4780: Further residue status fix
authorDaniel Silsby <dansilsby@gmail.com>
Wed, 29 Aug 2018 21:32:56 +0000 (23:32 +0200)
committerVinod Koul <vkoul@kernel.org>
Tue, 11 Sep 2018 07:29:26 +0000 (12:59 +0530)
commite01fbe86fbbd06d583f9ac67d9e0b26a4a1fe17d
tree8ff6dcb08770106064a0e22ceb410d586412beb1
parent4cc91c28bd62cda1cc01862edffe76b40a0cc6c8
dmaengine: dma-jz4780: Further residue status fix

Func jz4780_dma_desc_residue() expects the index to the next hw
descriptor as its last parameter. Caller func jz4780_dma_tx_status(),
however, applied modulus before passing it. When the current hw
descriptor was last in the list, the index passed became zero.

The resulting excess of reported residue especially caused problems
with cyclic DMA transfer clients, i.e. ALSA AIC audio output, which
rely on this for determining current DMA location within buffer.

Combined with the recent and related residue-reporting fixes, spurious
ALSA audio underruns on jz4770 hardware are now fixed.

Signed-off-by: Daniel Silsby <dansilsby@gmail.com>
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dma-jz4780.c