]> git.baikalelectronics.ru Git - kernel.git/commit
tracing/kprobes: Check whether get_kretprobe() returns NULL in kretprobe_dispatcher()
authorMasami Hiramatsu (Google) <mhiramat@kernel.org>
Fri, 27 May 2022 15:55:39 +0000 (00:55 +0900)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Fri, 17 Jun 2022 21:40:06 +0000 (17:40 -0400)
commitdff9bdf54b5ab6a0b9f433f5de1753a8b06c8fba
treebb9ee7db0041fb4dee12010424a227c85b866d1c
parent71374b58ebc7666369d670c06d1176f81c437c59
tracing/kprobes: Check whether get_kretprobe() returns NULL in kretprobe_dispatcher()

There is a small chance that get_kretprobe(ri) returns NULL in
kretprobe_dispatcher() when another CPU unregisters the kretprobe
right after __kretprobe_trampoline_handler().

To avoid this issue, kretprobe_dispatcher() checks the get_kretprobe()
return value again. And if it is NULL, it returns soon because that
kretprobe is under unregistering process.

This issue has been introduced when the kretprobe is decoupled
from the struct kretprobe_instance by commit 4fa79739c229
("kprobes: Remove kretprobe hash"). Before that commit, the
struct kretprob_instance::rp directly points the kretprobe
and it is never be NULL.

Link: https://lkml.kernel.org/r/165366693881.797669.16926184644089588731.stgit@devnote2
Reported-by: Yonghong Song <yhs@fb.com>
Fixes: 4fa79739c229 ("kprobes: Remove kretprobe hash")
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: bpf <bpf@vger.kernel.org>
Cc: Kernel Team <kernel-team@fb.com>
Cc: stable@vger.kernel.org
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_kprobe.c