]> git.baikalelectronics.ru Git - kernel.git/commit
dm mpath: fix racey management of PG initialization
authorMike Snitzer <snitzer@redhat.com>
Mon, 24 Aug 2020 18:19:55 +0000 (14:19 -0400)
committerMike Snitzer <snitzer@redhat.com>
Tue, 1 Sep 2020 20:41:56 +0000 (16:41 -0400)
commitdf2dba03269193a3ea5ef64175999b0373592c5f
tree2f7a395244b925895261a7386467a18054b3fc8c
parentf15ad228a615857e8b980373a5fbf63f0a4a0bd1
dm mpath: fix racey management of PG initialization

Commit 700261406f0c ("dm mpath: only flush workqueue when needed")
changed flush_multipath_work() to avoid needless workqueue
flushing (of a multipath global workqueue). But that change didn't
realize the surrounding flush_multipath_work() code should also only
run if 'pg_init_in_progress' is set.

Fix this by only doing all of flush_multipath_work()'s PG init related
work if 'pg_init_in_progress' is set.

Otherwise multipath_wait_for_pg_init_completion() will run
unconditionally but the preceeding flush_workqueue(kmpath_handlerd)
may not. This could lead to deadlock (though only if kmpath_handlerd
never runs a corresponding work to decrement 'pg_init_in_progress').

It could also be, though highly unlikely, that the kmpath_handlerd
work that does PG init completes before 'pg_init_in_progress' is set,
and then an intervening DM table reload's multipath_postsuspend()
triggers flush_multipath_work().

Fixes: 700261406f0c ("dm mpath: only flush workqueue when needed")
Cc: stable@vger.kernel.org
Reported-by: Ben Marzinski <bmarzins@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-mpath.c