]> git.baikalelectronics.ru Git - kernel.git/commit
afs: check function return
authorTom Rix <trix@redhat.com>
Fri, 30 Apr 2021 15:50:31 +0000 (08:50 -0700)
committerDavid Howells <dhowells@redhat.com>
Wed, 21 Jul 2021 14:10:23 +0000 (15:10 +0100)
commitde9e6ab8b97e72bbb2ad7b6b7e9de31a4cc8ad36
treeae592adeb8855f9ae68c146733898d85d91c2308
parent13277d816dd67d5db8b048dd1dab16ad36816d3e
afs: check function return

Static analysis reports this problem

write.c:773:29: warning: Assigned value is garbage or undefined
  mapping->writeback_index = next;
                           ^ ~~~~
The call to afs_writepages_region() can return without setting
next.  So check the function return before using next.

Changes:
 ver #2:
   - Need to fix the range_cyclic case also[1].

Fixes: 590fbc00891f ("afs: Prepare for use of THPs")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Link: https://lore.kernel.org/r/20210430155031.3287870-1-trix@redhat.com
Link: https://lore.kernel.org/r/CAB9dFdvHsLsw7CMnB+4cgciWDSqVjuij4mH3TaXnHQB8sz5rHw@mail.gmail.com/
Link: https://lore.kernel.org/r/162609464716.3133237.10354897554363093252.stgit@warthog.procyon.org.uk/
Link: https://lore.kernel.org/r/162610727640.3408253.8687445613469681311.stgit@warthog.procyon.org.uk/
fs/afs/write.c