]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: SOF: ipc-msg-injector: Use devm_kzalloc() for the rx_buffer
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Wed, 9 Mar 2022 11:01:04 +0000 (13:01 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 9 Mar 2022 17:34:59 +0000 (17:34 +0000)
commitde8c4e7ae72a5ba41d2c2a6dd1c9f37a5f54107a
tree04b4751e3b0ec9b858de4b81ae799ebfaccb7cb0
parent999872519effac0c223ae1892eb657df74f1b308
ASoC: SOF: ipc-msg-injector: Use devm_kzalloc() for the rx_buffer

The rx_buffer is cleared before sending an IPC to make sure that when the
/sys/kernel/debug/sof/ipc_msg_inject file is read we will have correct
information in the buffer (no random or stale data).

But if the user reads the file before sending any message the buffer might
contain garbage which should not be interpreted.

To prevent this, clear the rx_buffer on allocation.

Fixes: fe7be92b8b75 ("ASoC: SOF: Convert the generic IPC message injector into SOF client")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220309110104.18370-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/sof-client-ipc-msg-injector.c