]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "x86: signal: change type of paramter for sys_rt_sigreturn()"
authorIngo Molnar <mingo@elte.hu>
Tue, 20 Jan 2009 08:31:49 +0000 (09:31 +0100)
committerIngo Molnar <mingo@elte.hu>
Wed, 21 Jan 2009 08:43:18 +0000 (09:43 +0100)
commitde49e9fc8f30777123c7506c61760ca381336b7a
treecdebda18ea3360461358127091859610be2acf01
parent1985edb0bcede7c89c4d0af87597eb763255a903
Revert "x86: signal: change type of paramter for sys_rt_sigreturn()"

This reverts commit fccd8d2db6dfc50a7b1e96d6bb28b94d43282a45.

Justin Madru bisected this commit, it was causing weird Firefox
crashes.

The reason is that GCC mis-optimizes (re-uses) the on-stack parameters of
the calling frame, which corrupts the syscall return pt_regs state and
thus corrupts user-space register state.

So we go back to the slightly less clean but more optimization-safe
method of getting to pt_regs. Also add a comment to explain this.

Resolves: http://bugzilla.kernel.org/show_bug.cgi?id=12505

Reported-and-bisected-by: Justin Madru <jdm64@gawab.com>
Tested-by: Justin Madru <jdm64@gawab.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/include/asm/syscalls.h
arch/x86/kernel/signal.c