]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa/slave: Fix compilation warnings
authorviresh kumar <viresh.kumar@linaro.org>
Fri, 23 Nov 2012 19:53:54 +0000 (19:53 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 25 Nov 2012 21:11:47 +0000 (16:11 -0500)
commitde3d89d0e2023d6a66700bcd3b4a5948476e72b3
treead1bec537bfcfc8c7c434e9b564af43a54161a67
parent93e4935f2b66dc3bacae40a75a445e2f48c95186
net: dsa/slave: Fix compilation warnings

Currently when none of CONFIG_NET_DSA_TAG_DSA, CONFIG_NET_DSA_TAG_EDSA and
CONFIG_NET_DSA_TAG_TRAILER is defined, we get following compilation warnings:

net/dsa/slave.c:51:12: warning: 'dsa_slave_init' defined but not used [-Wunused-function]
net/dsa/slave.c:60:12: warning: 'dsa_slave_open' defined but not used [-Wunused-function]
net/dsa/slave.c:98:12: warning: 'dsa_slave_close' defined but not used [-Wunused-function]
net/dsa/slave.c:116:13: warning: 'dsa_slave_change_rx_flags' defined but not used [-Wunused-function]
net/dsa/slave.c:127:13: warning: 'dsa_slave_set_rx_mode' defined but not used [-Wunused-function]
net/dsa/slave.c:136:12: warning: 'dsa_slave_set_mac_address' defined but not used [-Wunused-function]
net/dsa/slave.c:164:12: warning: 'dsa_slave_ioctl' defined but not used [-Wunused-function]

Earlier approach to fix this was discussed here:

lkml.org/lkml/2012/10/29/549

This is another approach to fix it. This is done by some changes in config
options, which make more sense than the earlier approach. As, atleast one
tagging option must always be selected for using net/dsa/ infrastructure, this
patch selects NET_DSA from tagging configs instead of having it as an selectable
config.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/Kconfig
net/dsa/Kconfig