]> git.baikalelectronics.ru Git - kernel.git/commit
bonding: do not set slave_dev npinfo before slave_enable_netpoll in bond_enslave
authorXin Long <lucien.xin@gmail.com>
Sun, 22 Apr 2018 11:11:50 +0000 (19:11 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 23 Apr 2018 15:52:35 +0000 (11:52 -0400)
commitddea788c63094f7c483783265563dd5b50052e28
tree82a25c0e614ab025a24476c0ed166ac6add0b4fd
parent7e5a206ab686f098367b61aca989f5cdfa8114a3
bonding: do not set slave_dev npinfo before slave_enable_netpoll in bond_enslave

After Commit 8a8efa22f51b ("bonding: sync netpoll code with bridge"), it
would set slave_dev npinfo in slave_enable_netpoll when enslaving a dev
if bond->dev->npinfo was set.

However now slave_dev npinfo is set with bond->dev->npinfo before calling
slave_enable_netpoll. With slave_dev npinfo set, __netpoll_setup called
in slave_enable_netpoll will not call slave dev's .ndo_netpoll_setup().
It causes that the lower dev of this slave dev can't set its npinfo.

One way to reproduce it:

  # modprobe bonding
  # brctl addbr br0
  # brctl addif br0 eth1
  # ifconfig bond0 192.168.122.1/24 up
  # ifenslave bond0 eth2
  # systemctl restart netconsole
  # ifenslave bond0 br0
  # ifconfig eth2 down
  # systemctl restart netconsole

The netpoll won't really work.

This patch is to remove that slave_dev npinfo setting in bond_enslave().

Fixes: 8a8efa22f51b ("bonding: sync netpoll code with bridge")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c