]> git.baikalelectronics.ru Git - kernel.git/commit
HID: multitouch: do not blindly set EV_KEY or EV_ABS bits
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 11 Jul 2017 17:02:18 +0000 (10:02 -0700)
committerJiri Kosina <jkosina@suse.cz>
Thu, 13 Jul 2017 14:48:29 +0000 (16:48 +0200)
commitddb6ca27b551641da2faa496034ecd9ea27cc492
treec042e7652cef6d50c5b6c2bef44809c9debbd9b3
parent1f101dd5dcc259364068faf4f7bb5b4af15a6a28
HID: multitouch: do not blindly set EV_KEY or EV_ABS bits

Now that input core insists on having dev->absinfo when device claims to
generate EV_ABS in its dev->evbit, we should not be blindly setting that
bit.

The code in question might have been needed before input_set_abs_params()
started setting EV_ABS in device's evbit, but not anymore, and is now
breaking devices such as SMART SPNL-6075 Touchscreen.

Fixes: 7ce9eebcc787 ("Input: refuse to register absolute devices ...")
Reported-by: Matthias Fend <Matthias.Fend@wolfvision.net>
Tested-by: Matthias Fend <Matthias.Fend@wolfvision.net>
Cc: stable@vger.kernel.org
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-multitouch.c