]> git.baikalelectronics.ru Git - kernel.git/commit
dt-bindings: net: dwmac: fix 'mac-mode' type
authorAlexandru Ardelean <alexandru.ardelean@analog.com>
Tue, 17 Sep 2019 10:30:52 +0000 (13:30 +0300)
committerJakub Kicinski <jakub.kicinski@netronome.com>
Sat, 21 Sep 2019 00:10:35 +0000 (17:10 -0700)
commitdd87037c247dc59415556468d3d6baefa35f8083
treea3f41d64a4e715ba7a1a96c4ff17febb09e48309
parent321043b88e4cc038ba9733635157c413da5d9f0f
dt-bindings: net: dwmac: fix 'mac-mode' type

The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type',
which are enums of mode strings.

The 'dwmac' driver supports almost all modes declared in the 'phy-mode'
enum (except for 1 or 2). But in general, there may be a case where
'mac-mode' becomes more generic and is moved as part of phylib or netdev.

In any case, the 'mac-mode' field should be made an enum, and it also makes
sense to just reference the 'phy-connection-type' from
'ethernet-controller.yaml'. That will also make it more future-proof for new
modes.

Fixes: bdabd194766d ("dt-bindings: net: dwmac: document 'mac-mode' property")
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Documentation/devicetree/bindings/net/snps,dwmac.yaml