]> git.baikalelectronics.ru Git - kernel.git/commit
crypto: ccp - fix resource leaks in ccp_run_aes_gcm_cmd()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 26 Aug 2021 13:04:27 +0000 (16:04 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 24 Sep 2021 07:58:41 +0000 (15:58 +0800)
commitdd2f7f87815246de8798e92acc61ffea55f8e0d9
tree692d9c16d80eada7f6e5a115c5c7d48d8aa8de61
parent4ce062870c70d404088bf50de34ea03772413b4e
crypto: ccp - fix resource leaks in ccp_run_aes_gcm_cmd()

There are three bugs in this code:

1) If we ccp_init_data() fails for &src then we need to free aad.
   Use goto e_aad instead of goto e_ctx.
2) The label to free the &final_wa was named incorrectly as "e_tag" but
   it should have been "e_final_wa".  One error path leaked &final_wa.
3) The &tag was leaked on one error path.  In that case, I added a free
   before the goto because the resource was local to that block.

Fixes: 48c4c7bda886 ("crypto: ccp - Enable support for AES GCM on v5 CCPs")
Reported-by: "minihanshen(沈明航)" <minihanshen@tencent.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: John Allen <john.allen@amd.com>
Tested-by: John Allen <john.allen@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccp/ccp-ops.c