]> git.baikalelectronics.ru Git - kernel.git/commit
net: Fix race condition in store_rps_map
authorTom Herbert <tom@herbertland.com>
Wed, 5 Aug 2015 16:39:27 +0000 (09:39 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Aug 2015 22:56:56 +0000 (15:56 -0700)
commitdc4fa49c6087c678f79ff47fca4850c003dffff8
tree4cf760912a8c9e3447619d6cdaeeac0835e9eaae
parent8f5ef3d01b2801cc2fbf2ef31dc4cdc620c6032e
net: Fix race condition in store_rps_map

There is a race condition in store_rps_map that allows jump label
count in rps_needed to go below zero. This can happen when
concurrently attempting to set and a clear map.

Scenario:

1. rps_needed count is zero
2. New map is assigned by setting thread, but rps_needed count _not_ yet
   incremented (rps_needed count still zero)
2. Map is cleared by second thread, old_map set to that just assigned
3. Second thread performs static_key_slow_dec, rps_needed count now goes
   negative

Fix is to increment or decrement rps_needed under the spinlock.

Signed-off-by: Tom Herbert <tom@herbertland.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/net-sysfs.c