]> git.baikalelectronics.ru Git - kernel.git/commit
tty: cp210x: Fix carrier handling
authorAlan Cox <alan@linux.intel.com>
Wed, 28 Oct 2009 20:12:33 +0000 (21:12 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 18 Nov 2009 00:42:43 +0000 (16:42 -0800)
commitdc391daf141a6746aa271a4775bdae4f79b387e2
treee62139e4d349a68dd698070af7619a9ce5122386
parenteac2096058fbf1cb7be4ea36ff5b598628ec062d
tty: cp210x: Fix carrier handling

Original discussion:
http://thread.gmane.org/gmane.linux.usb.general/23217/focus=23248
or
http://marc.info/?l=linux-usb&m=125553790714133&w=2

a9b54cb6ed2e92ec6a9885c0641b54cbaddf0344 broke carrier handling so that a
cp210x setup which needed the carrier lines set up (non CLOCAL) which did
not make a call which set the termios bits left the lines down even if
CLOCAL was not asserted.

Fix this not by reverting but by adding the proper dtr_rts and
carrier_raised methods. This both sets the modem lines properly and also
implements the correct blocking semantics for the port as required by
POSIX.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Reported-by: Karl Hiramoto <karl@hiramoto.org>
Tested-by: Karl Hiramoto <karl@hiramoto.org>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/cp210x.c