]> git.baikalelectronics.ru Git - kernel.git/commit
drm/nouveau: prefer XBGR2101010 for addfb ioctl
authorIlia Mirkin <imirkin@alum.mit.edu>
Sat, 3 Feb 2018 19:11:23 +0000 (14:11 -0500)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 23 Feb 2018 12:51:42 +0000 (13:51 +0100)
commitdbec94401d2d77b154676322d8eddf8daca8e4f7
treefebffbe7b900db3467d757e05e939d2825918d88
parentfb653638a2c545b709e9f460e6c0ca5f91fc01bd
drm/nouveau: prefer XBGR2101010 for addfb ioctl

Nouveau only exposes support for XBGR2101010. Prior to the atomic
conversion, drm would pass in the wrong format in the framebuffer, but
it was always ignored -- both userspace (xf86-video-nouveau) and the
kernel driver agreed on the layout, so the fact that the format was
wrong didn't matter.

With the atomic conversion, nouveau all of a sudden started caring about
the exact format, and so the previously-working code in
xf86-video-nouveau no longer functioned since the (internally-assigned)
format from the addfb ioctl was wrong.

This change adds infrastructure to allow a drm driver to specify that it
prefers the XBGR format variant for the addfb ioctl, and makes nouveau's
nv50 display driver set it. (Prior gens had no support for 30bpp at all.)

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: stable@vger.kernel.org # v4.10+
Acked-by: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180203191123.31507-1-imirkin@alum.mit.edu
drivers/gpu/drm/drm_framebuffer.c
drivers/gpu/drm/nouveau/nv50_display.c
include/drm/drm_drv.h