]> git.baikalelectronics.ru Git - kernel.git/commit
iomap: Fix direct I/O write consistency check
authorAndreas Gruenbacher <agruenba@redhat.com>
Thu, 10 Sep 2020 15:26:16 +0000 (08:26 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Thu, 10 Sep 2020 15:26:16 +0000 (08:26 -0700)
commitdbe0a0570b3ba96ea546e77382fd359095df5daf
tree45410f7b3d7fe4e360785639699d6e2afdad1387
parent2c3c620b18316e0fcb90198c3a346d95e6f3edab
iomap: Fix direct I/O write consistency check

When a direct I/O write falls back to buffered I/O entirely, dio->size
will be 0 in iomap_dio_complete.  Function invalidate_inode_pages2_range
will try to invalidate the rest of the address space.  If there are any
dirty pages in that range, the write will fail and a "Page cache
invalidation failure on direct I/O" error will be logged.

On gfs2, this can be reproduced as follows:

  xfs_io \
    -c "open -ft foo" -c "pwrite 4k 4k" -c "close" \
    -c "open -d foo" -c "pwrite 0 4k"

Fix this by recognizing 0-length writes.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/iomap/direct-io.c