]> git.baikalelectronics.ru Git - kernel.git/commit
blk-cgroup: don't quiesce the queue on policy activate/deactivate
authorJens Axboe <axboe@fb.com>
Wed, 18 Jan 2017 22:37:27 +0000 (15:37 -0700)
committerJens Axboe <axboe@fb.com>
Wed, 18 Jan 2017 22:37:27 +0000 (15:37 -0700)
commitdbb90d9a35d80388e53c4e8d0fc06e19fb80b616
tree7d34184c97b07d1aed08731fff17dad9efbbcdf1
parenta40c17a9a492ac99320bd105f656e97d7e25042e
blk-cgroup: don't quiesce the queue on policy activate/deactivate

There's no potential harm in quiescing the queue, but it also doesn't
buy us anything. And we can't run the queue async for policy
deactivate, since we could be in the path of tearing the queue down.
If we schedule an async run of the queue at that time, we're racing
with queue teardown AFTER having we've already torn most of it down.

Reported-by: Omar Sandoval <osandov@fb.com>
Fixes: 7774b6a97c39 ("blk-cgroup: ensure that we clear the stop bit on quiesced queues")
Tested-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
block/blk-cgroup.c