]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: only return -errno or success from attr ->put_listent
authorEric Sandeen <sandeen@sandeen.net>
Tue, 5 Apr 2016 21:57:18 +0000 (07:57 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 5 Apr 2016 21:57:18 +0000 (07:57 +1000)
commitdb601c926dcd62c8111e5c18289d1d8785b8c7be
tree6ff4d9edda91b530deff6386dd796e6e91e6e121
parent3039f62d3fccb077513a4ffae4d1ef4609c1b724
xfs: only return -errno or success from attr ->put_listent

Today, the put_listent formatters return either 1 or 0; if
they return 1, some callers treat this as an error and return
it up the stack, despite "1" not being a valid (negative)
error code.

The intent seems to be that if the input buffer is full,
we set seen_enough or set count = -1, and return 1;
but some callers check the return before checking the
seen_enough or count fields of the context.

Fix this by only returning non-zero for actual errors
encountered, and rely on the caller to first check the
return value, then check the values in the context to
decide what to do.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_attr.h
fs/xfs/xfs_attr_list.c
fs/xfs/xfs_xattr.c