]> git.baikalelectronics.ru Git - kernel.git/commit
HID: wacom: Correct coordinate system of touchring and pen twist
authorJason Gerecke <killertofu@gmail.com>
Wed, 30 Aug 2017 22:13:26 +0000 (15:13 -0700)
committerJiri Kosina <jkosina@suse.cz>
Wed, 6 Sep 2017 09:01:19 +0000 (11:01 +0200)
commitdb441f8d9366d4cc40223d8730e4952b4f93b2a0
treec728c8d48a39d9030547daaa5d77e4b254300772
parentc6e2e44512b248b459745ce2f4239846d0e5431a
HID: wacom: Correct coordinate system of touchring and pen twist

The MobileStudio Pro, Cintiq Pro, and 2nd-gen Intuos Pro devices use a
different coordinate system for their touchring and pen twist than prior
devices. Prior devices had zero aligned to the tablet's left and would
increase clockwise. Userspace expects data from the kernel to be in this
old coordinate space, so adjustments are necessary.

While the coordinate system for pen twist is formally defined by the HID
standard, no such definition existed for the touchring at the time these
tablets were introduced. Future tablets are expected to report touchring
data using the same "zero-up clockwise-increasing" coordinate system
defined for twist.

Fixes: d307e63f80 ("HID: wacom: generic: Add support for height, tilt, and twist usages")
Fixes: 8f0faeae81 ("HID: wacom: Support 2nd-gen Intuos Pro's Bluetooth classic interface")
Fixes: 6656b57049 ("HID: wacom: generic: add support for touchring")
Cc: stable@vger.kernel.org # 4.10, 4.11
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Reviewed-by: Ping Cheng <ping.cheng@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/wacom_wac.c