]> git.baikalelectronics.ru Git - kernel.git/commit
tcp/dccp: remove obsolete WARN_ON() in icmp handlers
authorEric Dumazet <edumazet@google.com>
Thu, 17 Mar 2016 05:52:15 +0000 (22:52 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Mar 2016 01:06:40 +0000 (21:06 -0400)
commitdb2d91efdce3b02fbeabed15e1d0dd6f420f20ba
tree008b9f5e2820e85f881910bff5e21921eaa260db
parentcf327729dffe2f958e5406b61ebd4d61774dfb70
tcp/dccp: remove obsolete WARN_ON() in icmp handlers

Now SYN_RECV request sockets are installed in ehash table, an ICMP
handler can find a request socket while another cpu handles an incoming
packet transforming this SYN_RECV request socket into an ESTABLISHED
socket.

We need to remove the now obsolete WARN_ON(req->sk), since req->sk
is set when a new child is created and added into listener accept queue.

If this race happens, the ICMP will do nothing special.

Fixes: aaf9f4668c2b ("tcp/dccp: install syn_recv requests into ehash table")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Ben Lazarus <blazarus@google.com>
Reported-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dccp/ipv4.c
net/ipv4/tcp_ipv4.c