]> git.baikalelectronics.ru Git - kernel.git/commit
ixgbe: fix automatic LRO/RSC settings for low latency
authorAndy Gospodarek <andy@greyhouse.net>
Fri, 11 Jun 2010 12:47:03 +0000 (12:47 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Jun 2010 01:20:53 +0000 (18:20 -0700)
commitdb04e8e139453ff75abfcab845617f4cea1632c0
tree335150601c08e1eecb819ce638e11430235ba4c1
parent3f7574bc904132b8c93e2141ebbac69e1673ca6c
ixgbe: fix automatic LRO/RSC settings for low latency

This patch added to 2.6.34:

commit bf465e60b521337c2da7726ee74dbeedcd9b589f
Author: Jesse Brandeburg <jesse.brandeburg@intel.com>
Date:   Tue Apr 27 01:37:20 2010 +0000

    ixgbe: enable extremely low latency

introduced a feature where LRO (called RSC on the hardware) was disabled
automatically when setting rx-usecs to 0 via ethtool.  Some might not
like the fact that LRO was disabled automatically, but I'm fine with
that.  What I don't like is that LRO/RSC is automatically enabled when
rx-usecs is set >0 via ethtool.

This would certainly be a problem if the device was used for forwarding
and it was determined that the low latency wasn't needed after the
device was already forwarding.  I played around with saving the state of
LRO in the driver, but it just didn't seem worthwhile and would require
a small change to dev_disable_lro() that I did not like.

This patch simply leaves LRO disabled when setting rx-usecs >0 and
requires that the user enable it again.  An extra informational message
will also now appear in the log so users can understand why LRO isn't
being enabled as they expect.

Inconsistency of LRO setting first noticed by Stanislaw Gruszka.

Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
CC: Stanislaw Gruszka <sgruszka@redhat.com>
CC: stable@kernel.org
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ixgbe/ixgbe_ethtool.c