]> git.baikalelectronics.ru Git - kernel.git/commit
cdc-acm: do not reset notification buffer index upon urb unlinking
authorTobias Herzog <t-herzog@gmx.de>
Sat, 22 Sep 2018 20:11:10 +0000 (22:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 9 Oct 2018 14:13:42 +0000 (16:13 +0200)
commitdae3ddba36f8c337fb59cef07d564da6fc9b7551
tree817ca4e62e0e4e9976c96a24dc18d0cbc40917a7
parent9397940ed812b942c520e0c25ed4b2c64d57e8b9
cdc-acm: do not reset notification buffer index upon urb unlinking

Resetting the write index of the notification buffer on urb unlink (e.g.
closing a cdc-acm device from userspace) may lead to wrong interpretation
of further received notifications, in case the index is not 0 when urb
unlink happens (i.e. when parts of a notification already have been
transferred). On the device side there is no "reset" of the notification
transimission and thus we would get out of sync with the device.

Signed-off-by: Tobias Herzog <t-herzog@gmx.de>
Acked-by: Oliver Neukum <oneukum@suse.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/cdc-acm.c