]> git.baikalelectronics.ru Git - kernel.git/commit
net: systemport: Fix coalescing settings handling
authorFlorian Fainelli <f.fainelli@gmail.com>
Wed, 28 Mar 2018 22:15:37 +0000 (15:15 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Mar 2018 14:03:36 +0000 (10:03 -0400)
commitdad7e2a8c27e39447f9930618932b4b59395dc4b
tree5b1eeedf73b3226eb565c012a23786866cc6fc6f
parent9e9b6658ee6b0c7bda3d6efab5b2db70e4d0ce30
net: systemport: Fix coalescing settings handling

There were a number of issues with setting the RX coalescing parameters:

- we would not be preserving values that would have been configured
  across close/open calls, instead we would always reset to no timeout
  and 1 interrupt per packet, this would also prevent DIM from setting its
  default usec/pkts values

- when adaptive RX would be turned on, we woud not be fetching the
  default parameters, we would stay with no timeout/1 packet per
  interrupt until the estimator kicks in and changes that

- finally disabling adaptive RX coalescing while providing parameters
  would not be honored, and we would stay with whatever DIM had
  previously determined instead of the user requested parameters

Fixes: 30b30ca2a074 ("net: systemport: Implement adaptive interrupt coalescing")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Tal Gilboa <talgi@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bcmsysport.c
drivers/net/ethernet/broadcom/bcmsysport.h