]> git.baikalelectronics.ru Git - kernel.git/commit
[media] videobuf2-v4l2: Verify planes array in buffer dequeueing
authorSakari Ailus <sakari.ailus@linux.intel.com>
Sun, 3 Apr 2016 19:31:03 +0000 (16:31 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 13 Apr 2016 19:20:01 +0000 (16:20 -0300)
commitdac99946de37cdbf4ac026bcc17c945f2f2ab7d8
tree78e2a25eed9562278421f656904ebe8f30eff863
parent219ad8e761f49027b8f0ee18b95a6b6ab1fd6b22
[media] videobuf2-v4l2: Verify planes array in buffer dequeueing

When a buffer is being dequeued using VIDIOC_DQBUF IOCTL, the exact buffer
which will be dequeued is not known until the buffer has been removed from
the queue. The number of planes is specific to a buffer, not to the queue.

This does lead to the situation where multi-plane buffers may be requested
and queued with n planes, but VIDIOC_DQBUF IOCTL may be passed an argument
struct with fewer planes.

__fill_v4l2_buffer() however uses the number of planes from the dequeued
videobuf2 buffer, overwriting kernel memory (the m.planes array allocated
in video_usercopy() in v4l2-ioctl.c)  if the user provided fewer
planes than the dequeued buffer had. Oops!

Fixes: 726888d0e93d ("[media] media: videobuf2: Prepare to divide videobuf2")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Cc: stable@vger.kernel.org # for v4.4 and later
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/v4l2-core/videobuf2-v4l2.c