]> git.baikalelectronics.ru Git - kernel.git/commit
[ROSE/AX25] af_rose: rose_release() fix
authorJarek Poplawski <jarkao2@gmail.com>
Wed, 2 Apr 2008 06:56:17 +0000 (23:56 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 2 Apr 2008 06:56:17 +0000 (23:56 -0700)
commitd97c6f96f7c56b2ed682e7c6c4f988f046fea77b
treef38695b8fcdee173cf714222193c8f12274ba879
parentd5138480b49b56837ec01d81b3ff0a152bbd63d2
[ROSE/AX25] af_rose: rose_release() fix

rose_release() doesn't release sockets properly, e.g. it skips
sock_orphan(), so OOPSes are triggered in sock_def_write_space(),
which was observed especially while ROSE skbs were kfreed from
ax25_frames_acked(). There is also sock_hold() and lock_sock() added -
similarly to ax25_release(). Thanks to Bernard Pidoux for substantial
help in debugging this problem.

Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Reported-and-tested-by: Bernard Pidoux <bpidoux@free.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rose/af_rose.c