]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: hda/realtek - Fix speaker output regression on Thinkpad T570
authorTakashi Iwai <tiwai@suse.de>
Mon, 3 Dec 2018 09:44:15 +0000 (10:44 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 3 Dec 2018 09:44:15 +0000 (10:44 +0100)
commitd92f66f7f9774b3cb53a1022ef2281a8444c07a5
treed7610e0f8d8bbe01875ec512224a23e4d728f0fe
parentdbfc79e726c8d24a8de90bb27549019e837d250c
ALSA: hda/realtek - Fix speaker output regression on Thinkpad T570

We've got a regression report for some Thinkpad models (at least
T570s) which shows the too low speaker output volume.  The bisection
leaded to the commit 196daf6cada4 ("ALSA: hda/realtek - Enable Thinkpad
Dock device for ALC298 platform"), and it's basically adding the two
pin configurations for the dock, and looks harmless.

The real culprit seems, though, that the DAC assignment for the
speaker pin is implicitly assumed on these devices, i.e. pin NID 0x14
to be coupled with DAC NID 0x03.  When more pins are configured by the
commit above, the auto-parser changes the DAC assignment, and this
resulted in the regression.

As a workaround, just provide the fixed pin / DAC mapping table for
this Thinkpad fixup function.  It's no generic solution, but the
problem itself is pretty much device-specific, so must be good
enough.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1554304
Fixes: 196daf6cada4 ("ALSA: hda/realtek - Enable Thinkpad Dock device for ALC298 platform")
Cc: <stable@vger.kernel.org>
Reported-and-tested-by: Jeremy Cline <jcline@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_realtek.c