]> git.baikalelectronics.ru Git - kernel.git/commit
acer-wmi: fix regression in backlight detection
authorMichael Spang <mspang@csclub.uwaterloo.ca>
Thu, 12 Mar 2009 21:31:34 +0000 (14:31 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 12 Mar 2009 23:20:24 +0000 (16:20 -0700)
commitd9287fbe655417a6567edc4489a1a01755582fa3
tree42da774663a9093eeb5c42421d823013f781a761
parent362603b3c8b96c504e7193a58f958fc50804f225
acer-wmi: fix regression in backlight detection

Currently we disable the Acer WMI backlight device if there is no ACPI
backlight device.  As a result, we end up with no backlight device at all.
 We should instead disable it if there is an ACPI device, as the other
laptop drivers do.  This regression was introduced in 976772e ("Acer-WMI:
fingers off backlight if video.ko is serving this functionality").

Each laptop driver with backlight support got a similar change around
976772e.  The changes to the other drivers look correct; see e.g.
39ae4622 for a similar but correct change.  The regression is also in
2.6.28.

Signed-off-by: Michael Spang <mspang@csclub.uwaterloo.ca>
Acked-by: Thomas Renninger <trenn@suse.de>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Len Brown <len.brown@intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: <stable@kernel.org> [2.6.28.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/platform/x86/acer-wmi.c