]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: pcm: Avoid possible info leaks from PCM stream buffers
authorTakashi Iwai <tiwai@suse.de>
Wed, 11 Dec 2019 15:57:42 +0000 (16:57 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 14 Dec 2019 17:53:31 +0000 (18:53 +0100)
commitd8f517a5b4822fb066a90cea6c72c7a5b930cd1c
tree4281e5d7a7befcc7c1fe4638c806ebc852073a29
parentd53dec905ef7387eb7c8e33aea93940eff0b3506
ALSA: pcm: Avoid possible info leaks from PCM stream buffers

The current PCM code doesn't initialize explicitly the buffers
allocated for PCM streams, hence it might leak some uninitialized
kernel data or previous stream contents by mmapping or reading the
buffer before actually starting the stream.

Since this is a common problem, this patch simply adds the clearance
of the buffer data at hw_params callback.  Although this does only
zero-clear no matter which format is used, which doesn't mean the
silence for some formats, but it should be OK because the intention is
just to clear the previous data on the buffer.

Reported-by: Lionel Koenig <lionel.koenig@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20191211155742.3213-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_native.c