]> git.baikalelectronics.ru Git - kernel.git/commit
mtd: nand: sunxi: add missing of_node_put
authorJulia Lawall <julia.lawall@lip6.fr>
Wed, 18 Nov 2015 22:04:12 +0000 (23:04 +0100)
committerBrian Norris <computersforpeace@gmail.com>
Tue, 1 Dec 2015 01:55:03 +0000 (17:55 -0800)
commitd88c0dc29ac7ae3320ba33b8455041d7c89d769e
tree5e99a4563615f409b52eae996d418fec79fdd1a4
parent48c386803cc4c19a0e547fc9373ff98f52e383fe
mtd: nand: sunxi: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
+  of_node_put(child);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/nand/sunxi_nand.c