]> git.baikalelectronics.ru Git - kernel.git/commit
perf lock: Don't free "lock_seq_stat" if read_count isn't zero
authorLeo Yan <leo.yan@linaro.org>
Wed, 4 Nov 2020 09:42:29 +0000 (17:42 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 12 Nov 2020 20:55:41 +0000 (17:55 -0300)
commitd86f536ea5083ac8ec3d2b9e7ad48d250eb01127
treec18d260b13c73d8bcc13ef1265497c434df67109
parent6de6aa4523609ac8b2312c5e16bb3f6f648a3482
perf lock: Don't free "lock_seq_stat" if read_count isn't zero

When execute command "perf lock report", it hits failure and outputs log
as follows:

  perf: builtin-lock.c:623: report_lock_release_event: Assertion `!(seq->read_count < 0)' failed.
  Aborted

This is an imbalance issue.  The locking sequence structure
"lock_seq_stat" contains the reader counter and it is used to check if
the locking sequence is balance or not between acquiring and releasing.

If the tool wrongly frees "lock_seq_stat" when "read_count" isn't zero,
the "read_count" will be reset to zero when allocate a new structure at
the next time; thus it causes the wrong counting for reader and finally
results in imbalance issue.

To fix this issue, if detects "read_count" is not zero (means still have
read user in the locking sequence), goto the "end" tag to skip freeing
structure "lock_seq_stat".

Fixes: 327b133382fb ("perf lock: Fix state machine to recognize lock sequence")
Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Link: https://lore.kernel.org/r/20201104094229.17509-2-leo.yan@linaro.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-lock.c