]> git.baikalelectronics.ru Git - kernel.git/commit
gpio: GPIOHANDLE_GET_LINE_VALUES_IOCTL: Fix information leak
authorLars-Peter Clausen <lars@metafoo.de>
Tue, 18 Oct 2016 14:54:04 +0000 (16:54 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 21 Oct 2016 12:40:29 +0000 (14:40 +0200)
commitd82aa4a8f2e8df9673ddb099262355da4c9b99b1
tree163e2c1eba8af0ff3dad6149ef4b28c107cc2490
parente405f9fcb63602d35f7a419ededa3f952a395a72
gpio: GPIOHANDLE_GET_LINE_VALUES_IOCTL: Fix information leak

The GPIOHANDLE_GET_LINE_VALUES_IOCTL handler allocates a gpiohandle_data
struct on the stack and then passes it to copy_to_user(). But only the
first element of the values array in the struct is set, which leaves the
struct partially initialized.

This exposes the previous, potentially sensitive, stack content to the
issuing userspace application. To avoid this make sure that the struct is
fully initialized.

Cc: stable@vger.kernel.org
Fixes: 61f922db7221 ("gpio: userspace ABI for reading GPIO line events")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib.c