]> git.baikalelectronics.ru Git - kernel.git/commit
x86, cpuid: Add "volatile" to asm in native_cpuid()
authorSuresh Siddha <suresh.b.siddha@intel.com>
Thu, 17 Dec 2009 00:25:42 +0000 (16:25 -0800)
committerH. Peter Anvin <hpa@zytor.com>
Thu, 17 Dec 2009 00:30:57 +0000 (16:30 -0800)
commitd7b6a3e61056bbae8a8801fb161290afa6ae6d9d
treee56674f1da20a6df352ea17f3242d03b2648e229
parent074699f10477ca1b0b4565187c44c5f0b852e91f
x86, cpuid: Add "volatile" to asm in native_cpuid()

xsave_cntxt_init() does something like:

cpuid(0xd, ..); // find out what features FP/SSE/.. etc are supported

xsetbv(); // enable the features known to OS

cpuid(0xd, ..); // find out the size of the context for features enabled

Depending on what features get enabled in xsetbv(), value of the
cpuid.eax=0xd.ecx=0.ebx changes correspondingly (representing the
size of the context that is enabled).

As we don't have volatile keyword for native_cpuid(), gcc 4.1.2
optimizes away the second cpuid and the kernel continues to use
the cpuid information obtained before xsetbv(), ultimately leading to kernel
crash on processors supporting more state than the legacy FP/SSE.

Add "volatile" for native_cpuid().

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
LKML-Reference: <1261009542.2745.55.camel@sbs-t61.sc.intel.com>
Cc: stable@kernel.org
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
arch/x86/include/asm/processor.h