]> git.baikalelectronics.ru Git - kernel.git/commit
media: atomisp: Remove binary_supports_input_format
authorNathan Chancellor <natechancellor@gmail.com>
Wed, 27 May 2020 07:11:50 +0000 (09:11 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 11 Jun 2020 16:19:45 +0000 (18:19 +0200)
commitd76f6219e77422cb0a9ff7071ae083e62ade27da
tree64c390535c75cce3d0fa4a3a5e040f9c3a67da9d
parent8b4a7dfe57408f61009da0d15f88af3b2d561f23
media: atomisp: Remove binary_supports_input_format

Clang warns:

drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c:1707:64:
warning: implicit conversion from enumeration type 'const enum
ia_css_frame_format' to different enumeration type 'enum
atomisp_input_format' [-Wenum-conversion]
        binary_supports_input_format(xcandidate, req_in_info->format));
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~             ~~~~~~~~~~~~~^~~~~~

As it turns out, binary_supports_input_format only asserts that
xcandidate is not NULL and just returns true so this call is never
actually made.

There are other functions that are called that assert info is not NULL
so this function actually serves no purpose. Remove it. It can be
brought back if needed later.

Link: https://github.com/ClangBuiltLinux/linux/issues/1036
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c