]> git.baikalelectronics.ru Git - kernel.git/commit
apparmor: Use shash crypto API interface for profile hashes
authorTyler Hicks <tyhicks@canonical.com>
Sun, 29 Sep 2013 15:39:21 +0000 (08:39 -0700)
committerJames Morris <james.l.morris@oracle.com>
Sun, 29 Sep 2013 23:53:59 +0000 (09:53 +1000)
commitd766c59b8ad7fc199391d27d65b09974c5d80898
tree1826844de4bbe7ca69b79ad17adabf1ec52763d9
parent4b334a65369be36ee55758dc198154c20d226294
apparmor: Use shash crypto API interface for profile hashes

Use the shash interface, rather than the hash interface, when hashing
AppArmor profiles. The shash interface does not use scatterlists and it
is a better fit for what AppArmor needs.

This fixes a kernel paging BUG when aa_calc_profile_hash() is passed a
buffer from vmalloc(). The hash interface requires callers to handle
vmalloc() buffers differently than what AppArmor was doing. Due to
vmalloc() memory not being physically contiguous, each individual page
behind the buffer must be assigned to a scatterlist with sg_set_page()
and then the scatterlist passed to crypto_hash_update().

The shash interface does not have that limitation and allows vmalloc()
and kmalloc() buffers to be handled in the same manner.

BugLink: https://launchpad.net/bugs/1216294/
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=62261
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Acked-by: Seth Arnold <seth.arnold@canonical.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
security/apparmor/crypto.c