]> git.baikalelectronics.ru Git - kernel.git/commit
hinic: fix a bug of ndo_stop
authorLuo bin <luobin9@huawei.com>
Sun, 10 May 2020 19:01:08 +0000 (19:01 +0000)
committerJakub Kicinski <kuba@kernel.org>
Mon, 11 May 2020 03:02:01 +0000 (20:02 -0700)
commitd72f372495e0d2bc337004fa0d6df1ceb5b502ef
treee8611759a8882be80464760ba1bd08e32f64fe6a
parenta06e72a069d9c18c7e2fa3b461d02a6b2cec9d4c
hinic: fix a bug of ndo_stop

if some function in ndo_stop interface returns failure because of
hardware fault, must go on excuting rest steps rather than return
failure directly, otherwise will cause memory leak.And bump the
timeout for SET_FUNC_STATE to ensure that cmd won't return failure
when hw is busy. Otherwise hw may stomp host memory if we free
memory regardless of the return value of SET_FUNC_STATE.

Fixes: fb91310ccef1 ("net-next/hinic: Initialize hw interface")
Signed-off-by: Luo bin <luobin9@huawei.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c
drivers/net/ethernet/huawei/hinic/hinic_main.c