]> git.baikalelectronics.ru Git - kernel.git/commit
blk-iocost: Fix error on iocost_ioc_vrate_adj
authorWaiman Long <longman@redhat.com>
Tue, 21 Apr 2020 13:07:55 +0000 (09:07 -0400)
committerJens Axboe <axboe@kernel.dk>
Tue, 21 Apr 2020 15:49:36 +0000 (09:49 -0600)
commitd6c8e949a35d6906d6c03a50e9a9cdf4e494528a
treeb3e31a1639e2409c77ed2e1ca85eed35f57d9ffb
parentb849dd84b6ccfe32622988b79b7b073861fcf9f7
blk-iocost: Fix error on iocost_ioc_vrate_adj

Systemtap 4.2 is unable to correctly interpret the "u32 (*missed_ppm)[2]"
argument of the iocost_ioc_vrate_adj trace entry defined in
include/trace/events/iocost.h leading to the following error:

  /tmp/stapAcz0G0/stap_c89c58b83cea1724e26395efa9ed4939_6321_aux_6.c:78:8:
  error: expected ‘;’, ‘,’ or ‘)’ before ‘*’ token
   , u32[]* __tracepoint_arg_missed_ppm

That argument type is indeed rather complex and hard to read. Looking
at block/blk-iocost.c. It is just a 2-entry u32 array. By simplifying
the argument to a simple "u32 *missed_ppm" and adjusting the trace
entry accordingly, the compilation error was gone.

Fixes: 7caa47151ab2 ("blkcg: implement blk-iocost")
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Waiman Long <longman@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-iocost.c
include/trace/events/iocost.h