]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: don't call switchdev_bridge_port_unoffload for unoffloaded bridge ports
authorVladimir Oltean <vladimir.oltean@nxp.com>
Mon, 23 Aug 2021 21:22:55 +0000 (00:22 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Aug 2021 08:30:58 +0000 (09:30 +0100)
commitd6a4ec7b5dcd70ce5eaa411ce0494bc1f94f7429
treeeb0a88e31502e101c9329472a2f35b20fefc299d
parent293e5ec8380c2f427bcf5c1a1b107abd623ea568
net: dsa: don't call switchdev_bridge_port_unoffload for unoffloaded bridge ports

For ports that have a NULL dp->bridge_dev, dsa_port_to_bridge_port()
also returns NULL as expected.

Issue #1 is that we are performing a NULL pointer dereference on brport_dev.

Issue #2 is that these are ports on which switchdev_bridge_port_offload
has not been called, so we should not call switchdev_bridge_port_unoffload
on them either.

Both issues are addressed by checking against a NULL brport_dev in
dsa_port_pre_bridge_leave and exiting early.

Fixes: 4c3ab5d339ab ("net: bridge: switchdev: let drivers inform which bridge ports are offloaded")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/port.c