]> git.baikalelectronics.ru Git - kernel.git/commit
sch_sfq: fix null pointer dereference at timer expiration
authorPaolo Abeni <pabeni@redhat.com>
Tue, 28 Nov 2017 13:28:39 +0000 (14:28 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 28 Nov 2017 20:54:05 +0000 (15:54 -0500)
commitd663ac92083f54b9fd5154eb70ebaf555f6aded0
tree7b7b208dcc0d37e0f69b875e9142471fe50135be
parentbfb9bde730c0ced2aa2a5a12254f8e45dbe044b3
sch_sfq: fix null pointer dereference at timer expiration

While converting sch_sfq to use timer_setup(), the commit 39104f2154bd
("net: sched: Convert timers to use timer_setup()") forgot to
initialize the 'sch' field. As a result, the timer callback tries to
dereference a NULL pointer, and the kernel does oops.

Fix it initializing such field at qdisc creation time.

Fixes: 39104f2154bd ("net: sched: Convert timers to use timer_setup()")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_sfq.c