]> git.baikalelectronics.ru Git - kernel.git/commit
rcu: Allow rcu_irq_enter_check_tick() from NMI
authorPeter Zijlstra <peterz@infradead.org>
Mon, 16 Nov 2020 12:10:12 +0000 (13:10 +0100)
committerPaul E. McKenney <paulmck@kernel.org>
Fri, 20 Nov 2020 03:34:17 +0000 (19:34 -0800)
commitd5e948b634b7d15a2ecbee1f499cf3753f69d1d2
treef4f34a632bbf504557cb50c2412d80225f8b0576
parent10c4b0c51d7c4f6445128dec811407509ce28bec
rcu: Allow rcu_irq_enter_check_tick() from NMI

Eugenio managed to tickle #PF from NMI context which resulted in
hitting a WARN in RCU through irqentry_enter() ->
__rcu_irq_enter_check_tick().

However, this situation is perfectly sane and does not warrant an
WARN. The #PF will (necessarily) be atomic and not require messing
with the tick state, so early return is correct.  This commit
therefore removes the WARN.

Fixes: 43000005a917 ("rcu: Abstract out rcu_irq_enter_check_tick() from rcu_nmi_enter()")
Reported-by: "Eugenio Pérez" <eupm90@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
kernel/rcu/tree.c