]> git.baikalelectronics.ru Git - kernel.git/commit
xen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in pcistub_probe
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 9 Apr 2018 15:03:36 +0000 (23:03 +0800)
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>
Mon, 16 Apr 2018 14:19:52 +0000 (10:19 -0400)
commitd59cf8040a94dfc4ede0757a4ef3731dbdd3c5e0
tree3233467e63072bdcc82d3d2d1d76b1f83823c29d
parent1880aacd7de266d5aa59d68b986607c53a217ec8
xen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in pcistub_probe

pcistub_probe() is never called in atomic context.
This function is only set as ".probe" in struct pci_driver.

Despite never getting called from atomic context,
pcistub_probe() calls kmalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
drivers/xen/xen-pciback/pci_stub.c