]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "usb: host: ehci: Use dma_pool_zalloc()"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 May 2018 21:35:12 +0000 (14:35 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 May 2018 21:35:12 +0000 (14:35 -0700)
commitd4390ca8c0f4ba3528f72010def725220b2bfc8d
treed3e9d5117a2c8523fb82033273ba41c5e65277b5
parentd8251f3b30519a21b2be2a22c7d338ba13f499ae
Revert "usb: host: ehci: Use dma_pool_zalloc()"

This reverts commit 4efd8bdb5b8e19cab4ca98cca3194bda69578285 as it is
broken.

Alan writes:
What you can't see just from reading the patch is that in both
cases (ehci->itd_pool and ehci->sitd_pool) there are two
allocation paths -- the two branches of an "if" statement -- and
only one of the paths calls dma_pool_[z]alloc.  However, the
memset is needed for both paths, and so it can't be eliminated.
Given that it must be present, there's no advantage to calling
dma_pool_zalloc rather than dma_pool_alloc.

Reported-by: Erick Cafferata <erick@cafferata.me>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Souptick Joarder <jrdr.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-mem.c
drivers/usb/host/ehci-sched.c