]> git.baikalelectronics.ru Git - kernel.git/commit
riscv: Allow PROT_WRITE-only mmap()
authorAndrew Bresticker <abrestic@rivosinc.com>
Thu, 15 Sep 2022 19:37:02 +0000 (15:37 -0400)
committerPalmer Dabbelt <palmer@rivosinc.com>
Thu, 22 Sep 2022 16:44:59 +0000 (09:44 -0700)
commitd3cbf9913501a79a787fe6426227b55e192736a0
tree753bd494df1918d2330e0ca0b5739bdfb2b2b53a
parent2d9a573e53823cf521d076fa41a74090de02f3aa
riscv: Allow PROT_WRITE-only mmap()

Commit 106b53788afb ("riscv: mmap with PROT_WRITE but no PROT_READ is
invalid") made mmap() return EINVAL if PROT_WRITE was set wihtout
PROT_READ with the justification that a write-only PTE is considered a
reserved PTE permission bit pattern in the privileged spec. This check
is unnecessary since we let VM_WRITE imply VM_READ on RISC-V, and it is
inconsistent with other architectures that don't support write-only PTEs,
creating a potential software portability issue. Just remove the check
altogether and let PROT_WRITE imply PROT_READ as is the case on other
architectures.

Note that this also allows PROT_WRITE|PROT_EXEC mappings which were
disallowed prior to the aforementioned commit; PROT_READ is implied in
such mappings as well.

Fixes: 106b53788afb ("riscv: mmap with PROT_WRITE but no PROT_READ is invalid")
Reviewed-by: Atish Patra <atishp@rivosinc.com>
Signed-off-by: Andrew Bresticker <abrestic@rivosinc.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20220915193702.2201018-3-abrestic@rivosinc.com/
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/kernel/sys_riscv.c