]> git.baikalelectronics.ru Git - kernel.git/commit
crypto: lib/mpi - avoid null pointer deref in mpi_cmp_ui()
authorMark O'Donovan <shiftee@posteo.net>
Fri, 4 Aug 2023 09:32:18 +0000 (09:32 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Sep 2023 09:11:02 +0000 (11:11 +0200)
commitd3ad023a39f1127dcfd331c562673355dc078650
tree5baa6fbe71d64ae99baf2ce8cbc90aa83835a6f1
parente5d94c98a72f5f8047facb290d3af748fe86b461
crypto: lib/mpi - avoid null pointer deref in mpi_cmp_ui()

[ Upstream commit 9e47a758b70167c9301d2b44d2569f86c7796f2d ]

During NVMeTCP Authentication a controller can trigger a kernel
oops by specifying the 8192 bit Diffie Hellman group and passing
a correctly sized, but zeroed Diffie Hellamn value.
mpi_cmp_ui() was detecting this if the second parameter was 0,
but 1 is passed from dh_is_pubkey_valid(). This causes the null
pointer u->d to be dereferenced towards the end of mpi_cmp_ui()

Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
lib/mpi/mpi-cmp.c