]> git.baikalelectronics.ru Git - kernel.git/commit
tipc: simplify include dependencies
authorJon Paul Maloy <jon.maloy@ericsson.com>
Thu, 14 May 2015 14:46:13 +0000 (10:46 -0400)
committerDavid S. Miller <davem@davemloft.net>
Thu, 14 May 2015 16:24:45 +0000 (12:24 -0400)
commitd29ed788068553504f1fa829f99feb2de6f545e0
tree11ca9a3895e3976b9f3ab34b3ce79d077076ae03
parenta85347af7aeed8b07c9e7008e67617ef053d2f69
tipc: simplify include dependencies

When we try to add new inline functions in the code, we sometimes
run into circular include dependencies.

The main problem is that the file core.h, which really should be at
the root of the dependency chain, instead is a leaf. I.e., core.h
includes a number of header files that themselves should be allowed
to include core.h. In reality this is unnecessary, because core.h does
not need to know the full signature of any of the structs it refers to,
only their type declaration.

In this commit, we remove all dependencies from core.h towards any
other tipc header file.

As a consequence of this change, we can now move the function
tipc_own_addr(net) from addr.c to addr.h, and make it inline.

There are no functional changes in this commit.

Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/addr.c
net/tipc/addr.h
net/tipc/bearer.h
net/tipc/core.h
net/tipc/net.c
net/tipc/node.c
net/tipc/node.h
net/tipc/socket.c