]> git.baikalelectronics.ru Git - kernel.git/commit
regmap: sdw: use _no_pm functions in regmap_read/write
authorBard Liao <yung-chuan.liao@linux.intel.com>
Fri, 22 Jan 2021 07:06:30 +0000 (15:06 +0800)
committerVinod Koul <vkoul@kernel.org>
Thu, 11 Feb 2021 05:24:00 +0000 (10:54 +0530)
commitd288a5712ef961e16d588bbdb2d846e00b5ef154
tree34690b202118d82dd4ca50fafae0b1fd055abf6e
parent957e3f797917b36355766807b1d8a54a1ba0cfc9
regmap: sdw: use _no_pm functions in regmap_read/write

sdw_update_slave_status will be invoked when a codec is attached,
and the codec driver will initialize the codec with regmap functions
while the codec device is pm_runtime suspended.

regmap routines currently rely on regular SoundWire IO functions,
which will call pm_runtime_get_sync()/put_autosuspend.

This causes a deadlock where the resume routine waits for an
initialization complete signal that while the initialization complete
can only be reached when the resume completes.

The only solution if we allow regmap functions to be used in resume
operations as well as during codec initialization is to use _no_pm
routines. The duty of making sure the bus is operational needs to be
handled above the regmap level.

Fixes: 7c22ce6e21840 ('regmap: Add SoundWire bus support')
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Acked-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20210122070634.12825-6-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/base/regmap/regmap-sdw.c