]> git.baikalelectronics.ru Git - kernel.git/commit
netpoll: Remove gfp parameter from __netpoll_setup
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 27 Mar 2014 22:36:38 +0000 (15:36 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 29 Mar 2014 21:58:37 +0000 (17:58 -0400)
commitd1fbd25443976e9db98877e322c619395daad1fe
tree26c3e8d991b42c16f48c99e4f9fd117233ae8b21
parentd00fc5a4073a062a0bb0d3dcbc4c9262770b48b4
netpoll: Remove gfp parameter from __netpoll_setup

The gfp parameter was added in:
commit 913337a48092aea896e5c9d2624cddea440c4ea9
Author: Amerigo Wang <amwang@redhat.com>
Date:   Fri Aug 10 01:24:37 2012 +0000

    netpoll: use GFP_ATOMIC in slave_enable_netpoll() and __netpoll_setup()

    slave_enable_netpoll() and __netpoll_setup() may be called
    with read_lock() held, so should use GFP_ATOMIC to allocate
    memory. Eric suggested to pass gfp flags to __netpoll_setup().

Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Cong Wang <amwang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
The reason for the gfp parameter was removed in:
commit 63513f5b8cd9e974f41c98962d7e8d0e5f3b61f0
Author: dingtianhong <dingtianhong@huawei.com>
Date:   Tue Jul 23 15:25:27 2013 +0800

    bonding: don't call slave_xxx_netpoll under spinlocks

    The slave_xxx_netpoll will call synchronize_rcu_bh(),
    so the function may schedule and sleep, it should't be
    called under spinlocks.

    bond_netpoll_setup() and bond_netpoll_cleanup() are always
    protected by rtnl lock, it is no need to take the read lock,
    as the slave list couldn't be changed outside rtnl lock.

Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Cc: Jay Vosburgh <fubar@us.ibm.com>
Cc: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Nothing else that calls __netpoll_setup or ndo_netpoll_setup
requires a gfp paramter, so remove the gfp parameter from both
of these functions making the code clearer.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c
drivers/net/team/team.c
include/linux/netdevice.h
include/linux/netpoll.h
net/8021q/vlan_dev.c
net/bridge/br_device.c
net/bridge/br_if.c
net/bridge/br_private.h
net/core/netpoll.c