]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/display: Fix an unsigned subtraction which can never be negative.
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Fri, 10 Dec 2021 04:41:24 +0000 (20:41 -0800)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 14 Dec 2021 09:11:10 +0000 (04:11 -0500)
commitd1d0f61556afd95650492efba2e7ca52a8e47a32
treed5bcaa6e13c082e4950a1f6931b5104dd1525e2b
parentc218e0b6cbbdf0307713783ed79056cea7414e80
drm/i915/display: Fix an unsigned subtraction which can never be negative.

smatch warning:
drivers/gpu/drm/i915/display/intel_dmc.c:601 parse_dmc_fw() warn:
unsigned 'fw->size - offset' is never less than zero

Firmware size is size_t and offset is u32. So the subtraction is
unsigned which can never be less than zero.

Fixes: 9786debf12f7 ("drm/i915/xelpd: Pipe A DMC plugging")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211210044129.12422-1-harshit.m.mogalapalli@oracle.com
(cherry picked from commit 87bb2a410dcfb617b88e4695edf4beb6336dc314)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/display/intel_dmc.c