]> git.baikalelectronics.ru Git - kernel.git/commit
net: switchdev: do not propagate bridge updates across bridges
authorRussell King <rmk+kernel@armlinux.org.uk>
Wed, 26 Feb 2020 17:14:21 +0000 (17:14 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Oct 2021 07:54:24 +0000 (09:54 +0200)
commitd1ade6ee1044b9f5e6c9b80379d7b508f08cc615
tree4d21c5fa5f7b9d980945b624346709f54386fa6a
parent53779084b7862aaf14d20bdc3001b3c880cc4038
net: switchdev: do not propagate bridge updates across bridges

commit 07c6f9805f12f1bb538ef165a092b300350384aa upstream.

When configuring a tree of independent bridges, propagating changes
from the upper bridge across a bridge master to the lower bridge
ports brings surprises.

For example, a lower bridge may have vlan filtering enabled.  It
may have a vlan interface attached to the bridge master, which may
then be incorporated into another bridge.  As soon as the lower
bridge vlan interface is attached to the upper bridge, the lower
bridge has vlan filtering disabled.

This occurs because switchdev recursively applies its changes to
all lower devices no matter what.

Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Tested-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Fabian Bläse <fabian@blaese.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/switchdev/switchdev.c