]> git.baikalelectronics.ru Git - kernel.git/commit
btrfs: test for valid bdev before kobj removal in btrfs_rm_device
authorEric Sandeen <sandeen@redhat.com>
Mon, 7 Jul 2014 17:34:49 +0000 (12:34 -0500)
committerChris Mason <clm@fb.com>
Sat, 19 Jul 2014 18:49:44 +0000 (11:49 -0700)
commitd1754631f0e0eb32ea005fdbe679413593f5a377
tree4c9a5a9f514ea6d955856b9ed28a3b63b3460b42
parente6e45f1ceff48cc23c5166595ef2d563f50bb99e
btrfs: test for valid bdev before kobj removal in btrfs_rm_device

commit b9cc539 btrfs: dev delete should remove sysfs entry
added a btrfs_kobj_rm_device, which dereferences device->bdev...
right after we check whether device->bdev might be NULL.

I don't honestly know if it's possible to have a NULL device->bdev
here, but assuming that it is (given the test), we need to move
the kobject removal to be under that test.

(Coverity spotted this)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Chris Mason <clm@fb.com>
fs/btrfs/volumes.c