]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: line6: Fix endless MIDI read loop
authorTakashi Iwai <tiwai@suse.de>
Mon, 9 Mar 2020 09:59:22 +0000 (10:59 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 9 Mar 2020 10:00:45 +0000 (11:00 +0100)
commitd13f5facfaa787d15f640e47e9460124a3aed725
treeb103ebcbd4c8d22ffd5c6642b80b47fb0011aa88
parent5028daa3ed6b3419b906c0ac52fc2eda2756e96b
ALSA: line6: Fix endless MIDI read loop

The MIDI input event parser of the LINE6 driver may enter into an
endless loop when the unexpected data sequence is given, as it tries
to continue the secondary bytes without termination.  Also, when the
input data is too short, the parser returns a negative error, while
the caller doesn't handle it properly.  This would lead to the
unexpected behavior as well.

This patch addresses those issues by checking the return value
correctly and handling the one-byte event in the parser properly.

The bug was reported by syzkaller.

Reported-by: syzbot+cce32521ee0a824c21f7@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/000000000000033087059f8f8fa3@google.com
Link: https://lore.kernel.org/r/20200309095922.30269-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/line6/driver.c
sound/usb/line6/midibuf.c